Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions update.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@ func (b UpdateBuilder) SetMap(clauses map[string]interface{}) UpdateBuilder {

// From adds FROM clause to the query
// FROM is valid construct in postgresql only.
func (b UpdateBuilder) From(from string) UpdateBuilder {
return builder.Set(b, "From", newPart(from)).(UpdateBuilder)
func (b UpdateBuilder) From(from string, args ...interface{}) UpdateBuilder {
return builder.Set(b, "From", newPart(from, args...)).(UpdateBuilder)
}

// FromSelect sets a subquery into the FROM clause of the query.
Expand Down
20 changes: 20 additions & 0 deletions update_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,26 @@ func TestUpdateBuilderFrom(t *testing.T) {
assert.Equal(t, "UPDATE employees SET sales_count = ? FROM accounts WHERE accounts.name = ?", sql)
}

func TestUpdateBuilderParamFrom(t *testing.T) {
fromArgs := []interface{}{
1, 5,
2, 5,
}
sql, _, err := Update("employees").
Set("sales_count", Expr("c.sales_count")).
From("(VALUES (?, ?), (?, ?)) AS c(id, sales_count)", fromArgs...).
Where("id = c.id").
ToSql()
assert.NoError(t, err)

expectedSql :=
"UPDATE employees " +
"SET sales_count = c.sales_count " +
"FROM (VALUES (?, ?), (?, ?)) AS c(id, sales_count) " +
"WHERE id = c.id"
assert.Equal(t, expectedSql, sql)
}

func TestUpdateBuilderFromSelect(t *testing.T) {
sql, _, err := Update("employees").
Set("sales_count", 100).
Expand Down