Custom Core dns with HPA for all Cloud Providers #134
Conversation
aws ttl config remove azure changes from this pr add azure module back
jshiwamV
changed the title
aws/examples/simple/main.tf
Outdated
| module.eks, | ||
| module.base_node_group, | ||
| module.networking, | ||
| module.coredns, |
There was a problem hiding this comment.
I actually don't think Karpenter or any of its EC2NodeClasses or NodePools need coredns, since Karpenter is configured for Default DNS mode, which doesn't use coredns. (Default is to point at the cloud provider's DNS server outside the cluster. The default DNS mode for pods is ClusterFirst, not Default).
This is fine, I won't block the PR for this one. It's just unnecessary.
There was a problem hiding this comment.
(Default is to point at the cloud provider's DNS server outside the cluster. The default DNS mode for pods is ClusterFirst, not Default).
how about the daemonsets that would run on karpenter nodes, those would rely on Coredns isn't it? Since Pod DNS mode is ClusterFirst. So it makes sense to bring up coredns before provisioning karpenter nodes?
There was a problem hiding this comment.
I guess you're right. Karpenter and the node classes don't need it, but the nodepools do.
Closing Disable TTL cache in coredns AWS #128 and Custom CoreDNS for GCP and Azure #132 in favour of this PR since it covers for both of them