Skip to content

Revert "persist: register schema at write time, not writer open time" #33984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bkirwi merged 1 commit into from
Oct 30, 2025
Merged

Revert "persist: register schema at write time, not writer open time" #33984

bkirwi merged 1 commit into from
Oct 30, 2025

Conversation

@teskje
Copy link
Contributor

@teskje teskje commented Oct 30, 2025

This reverts #33902.

We noticed that this change coincides with a persist panic in CI and some worrying persist compaction schema metrics.

See Slack thread.

Motivation

  • This PR fixes a recognized bug.

Fixes https://github.com/MaterializeInc/database-issues/issues/9874

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@teskje
Revert "Merge pull request MaterializeInc#33902 from teskje/persist-d…
7a8fa3c 
…efer-register-schema"

This reverts commit d2b1b58, reversing
changes made to dd3402f.
@teskje teskje requested review from a team and aljoscha as code owners October 30, 2025 18:25
@teskje teskje requested a review from bkirwi October 30, 2025 18:25
bkirwi
bkirwi approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@bkirwi bkirwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bkirwi bkirwi merged commit f5b7757 into MaterializeInc:main Oct 30, 2025
125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkirwi bkirwi bkirwi approved these changes

@aljoscha aljoscha Awaiting requested review from aljoscha aljoscha is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teskje @bkirwi