<fix>[vm]: use max of virtual and actual size for root disk allocation#3333
Open
zstack-robot-1 wants to merge 1 commit into5.5.6from
Open
<fix>[vm]: use max of virtual and actual size for root disk allocation#3333zstack-robot-1 wants to merge 1 commit into5.5.6from
zstack-robot-1 wants to merge 1 commit into5.5.6from
Conversation
…isk offering Resolves: ZSTAC-74683 Change-Id: Id0339ed0221e92e506f60745cde972cc3ee6d9ae
概览修改了在没有根磁盘产品时的根磁盘大小回退计算逻辑。将直接返回镜像清单大小改为返回镜像清单大小和实际大小的最大值。 变更项
代码审查工作量估计🎯 2 (Simple) | ⏱️ ~8 分钟 诗歌
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getRootDiskAllocateSize()仅用image.getSize()(virtual size),未考虑 actualSize 可能更大Math.max(virtualSize, actualSize)确保分配足够空间Files Changed
VmInstanceSpec.java— getRootDiskAllocateSize() 取 max(virtualSize, actualSize)Resolves: ZSTAC-74683
sync from gitlab !9155