Skip to content

Conversation

@rocky
Copy link
Member

@rocky rocky commented Dec 17, 2025

Using newly released on PyPI Timed-Threads for TimeConstrained[] further running on Python 3.14+ packaging more easily.

@rocky rocky marked this pull request as draft December 17, 2025 22:32
@rocky rocky changed the title Using modified stopit for timeconstrained Use python Timed-Threads for TimeConstrained[] Dec 18, 2025
@rocky rocky force-pushed the using_modified_stopit_for_timeconstrained branch 3 times, most recently from ceef415 to 147d252 Compare December 18, 2025 09:39
@rocky rocky marked this pull request as ready for review December 18, 2025 21:45
run: |
sudo apt update -qq && sudo apt install llvm-dev remake
python -m pip install --upgrade pip
# First, install our Timed-Threads
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmatera Now that we have a package that can be installed from PyPI should it be a required package (except when installing from pyodide and in that case dropped), or an optional one where we also install it here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is OK to include it as a default package. Then maybe we can move the TimeConstrained tests to the tests in TimedThreads.

@rocky rocky force-pushed the using_modified_stopit_for_timeconstrained branch from a6ea787 to a8012e1 Compare December 22, 2025 12:08
@rocky rocky changed the title Use python Timed-Threads for TimeConstrained[] Use PyPI Timed-Threads for TimeConstrained[] Dec 22, 2025
@rocky
Copy link
Member Author

rocky commented Dec 22, 2025

@mmatera: now that Timed-Threads has been removed from explicit install in workflows CI, I think we are ready for a merge to master. Right?

@mmatera
Copy link
Contributor

mmatera commented Dec 22, 2025

@mmatera: now that Timed-Threads has been removed from explicit install in workflows CI, I think we are ready for a merge to master. Right?

sure. LGTM

@rocky rocky merged commit 68c24ee into master Dec 22, 2025
17 checks passed
@rocky rocky deleted the using_modified_stopit_for_timeconstrained branch December 22, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants