-
-
Notifications
You must be signed in to change notification settings - Fork 62
Use PyPI Timed-Threads for TimeConstrained[]
#1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Timed-Threads for TimeConstrained[]
ceef415 to
147d252
Compare
| run: | | ||
| sudo apt update -qq && sudo apt install llvm-dev remake | ||
| python -m pip install --upgrade pip | ||
| # First, install our Timed-Threads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmatera Now that we have a package that can be installed from PyPI should it be a required package (except when installing from pyodide and in that case dropped), or an optional one where we also install it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is OK to include it as a default package. Then maybe we can move the TimeConstrained tests to the tests in TimedThreads.
a6ea787 to
a8012e1
Compare
Timed-Threads for TimeConstrained[]Timed-Threads for TimeConstrained[]
|
@mmatera: now that Timed-Threads has been removed from explicit install in workflows CI, I think we are ready for a merge to master. Right? |
sure. LGTM |
Using newly released on PyPI Timed-Threads for
TimeConstrained[]further running on Python 3.14+ packaging more easily.