Remove "value" from Symbol; add SymbolConstant...#714
Conversation
from PredefinedConstant. Doc strings have been over.
| return operator | ||
|
|
||
| precedence = prec.value | ||
| precedence = prec.value if hasattr(prec, "value") else 0 |
There was a problem hiding this comment.
@rocky, maybe it would be better to set the default to 670 (which is the default for precedence).
There was a problem hiding this comment.
0 means no parenthesis ever. 670 adds a parenthesis for everything except Get <<.
So restating, are you sure we want parenthesis most of the time?
There was a problem hiding this comment.
OK, in that case, let's keep 0...
There was a problem hiding this comment.
In another PR we may add a constant named "NEVER_ADD_PARENTHESIS". There was more refactoring oef the parenthesize function going on in #691
|
I will let this sit for a day, and if there are no comments or objections, I'll merge. |
|
Regarding this PR, I agree that Symbols should not have a "value" property. |
mmatera
left a comment
mmatera
left a comment
There was a problem hiding this comment.
apart from the comment, LGTM
2 participants
from PredefinedConstant.
Doc strings have been over.
This includes some of the stuff from #691. I think there is a little other stuff from that which should go in. But this narrows the differences.