Skip to content

Log inner exceptions even whe outer exception has no stack trace frames #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hotn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Log inner exceptions even whe outer exception has no stack trace frames #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 26 additions & 25 deletions src/app/SharpBrake/AirbrakeNoticeBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,40 +251,41 @@ private AirbrakeTraceLine[] BuildBacktrace(Exception exception, out MethodBase c
// Airbrake requires that at least one line is present in the XML.
AirbrakeTraceLine line = new AirbrakeTraceLine("none", 0);
lines.Add(line);
return lines.ToArray();
}

foreach (StackFrame frame in frames)
else
{
MethodBase method = frame.GetMethod();
foreach (StackFrame frame in frames)
{
MethodBase method = frame.GetMethod();

catchingMethod = method;
catchingMethod = method;

int lineNumber = frame.GetFileLineNumber();
int lineNumber = frame.GetFileLineNumber();

if (lineNumber == 0)
{
this.log.Debug(f => f("No line number found in {0}, using IL offset instead.", method));
lineNumber = frame.GetILOffset();
}
if (lineNumber == 0)
{
this.log.Debug(f => f("No line number found in {0}, using IL offset instead.", method));
lineNumber = frame.GetILOffset();
}

string file = frame.GetFileName();
string file = frame.GetFileName();

if (String.IsNullOrEmpty(file))
{
// ReSharper disable ConditionIsAlwaysTrueOrFalse
file = method.ReflectedType != null
? method.ReflectedType.FullName
: "(unknown)";
// ReSharper restore ConditionIsAlwaysTrueOrFalse
}
if (String.IsNullOrEmpty(file))
{
// ReSharper disable ConditionIsAlwaysTrueOrFalse
file = method.ReflectedType != null
? method.ReflectedType.FullName
: "(unknown)";
// ReSharper restore ConditionIsAlwaysTrueOrFalse
}

AirbrakeTraceLine line = new AirbrakeTraceLine(file, lineNumber)
{
Method = method.Name
};
AirbrakeTraceLine line = new AirbrakeTraceLine(file, lineNumber)
{
Method = method.Name
};

lines.Add(line);
lines.Add(line);
}
}

if (Configuration.LogInnerExceptions)
Expand Down