fix: use locked instead of frozen #889
Conversation
Frozen blindly install lock file without looking at the pyproject.toml This is nice for docker images, but for CI we should use locked. It checked the pyproject.toml and the lock file are in sync before installing the dependencies. Change-Id: I4d107f359df9567dd30ff5554b68198e6a19de99
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
🧪 CI InsightsHere's what we observed from your CI run for 083ea20. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow to use the --locked flag instead of --frozen when running UV commands. The --locked flag ensures that both pyproject.toml and the lock file are in sync before installing dependencies, which is more appropriate for CI environments than --frozen, which blindly installs from the lock file without validation.
Key Changes:
- Replaced
--frozenwith--lockedin UV run commands for both linters and tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge Queue Status✅ The pull request has been merged at 083ea20 This pull request spent 12 seconds in the queue, with no time running CI. Required conditions to merge
|
mergify
bot
deleted the
devs/sileht/uv-fix-frozen/I4d107f359df9567dd30ff5554b68198e6a19de99
branch
3 participants
Frozen blindly install lock file without looking at the pyproject.toml
This is nice for docker images, but for CI we should use locked.
It checked the pyproject.toml and the lock file are in sync before
installing the dependencies.