chore: better base detection debug #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for b15160c. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Pull request overview
This PR refactors the git reference detection system to improve debugging capabilities by tracking the source of base/head SHA detection. The change replaces the boolean is_merge_queue field with a more descriptive source field that uses a typed literal to indicate where the references were detected from.
Key Changes:
- Introduced a
ReferencesSourcetype with values like "manual", "merge_queue", "github_event_pull_request", etc. - Updated the
Referencesdataclass to usesource: ReferencesSourceinstead ofis_merge_queue: bool - Modified CLI output to display the source of detected references for better debugging
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mergify_cli/ci/git_refs/detector.py | Added ReferencesSource literal type and replaced is_merge_queue field with source in the References dataclass |
| mergify_cli/ci/cli.py | Updated scopes command to create References with "manual" source when base/head are provided via CLI options |
| mergify_cli/ci/scopes/cli.py | Modified detect() and maybe_write_github_step_summary() to accept References object and display source information |
| mergify_cli/tests/ci/git_refs/test_git_refs_detector.py | Updated test assertions to use the new source field with appropriate values |
| mergify_cli/tests/ci/scopes/test_cli.py | Updated test mocks and assertions to use References objects with correct source values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jd
previously approved these changes
Dec 19, 2025
This change introduces the source of where we found the base/head sha This will help debuging Customer CI. Change-Id: I74a4910647e62f85135e6d5245e5c329c8503007
sileht
force-pushed
the
devs/sileht/mq-bug-base/I74a4910647e62f85135e6d5245e5c329c8503007
branch
from
0d7c61e to
b15160c
Compare
JulianMaurin
approved these changes
Dec 22, 2025
Syffe
approved these changes
Dec 22, 2025
Contributor
Merge Queue Status✅ The pull request has been merged at b15160c This pull request spent 22 seconds in the queue, including 3 seconds running CI. Required conditions to merge
|
mergify
bot
deleted the
devs/sileht/mq-bug-base/I74a4910647e62f85135e6d5245e5c329c8503007
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the source of where we found the base/head sha
This will help debuging Customer CI.