-
Notifications
You must be signed in to change notification settings - Fork 1
Feed "label for plots" through as an "alias" in ESMValTool recipe #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # CMEW/meta/rose-meta.conf
…alias' into 298_feed_model_label_through_as_alias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I run the tests and the metoffice workflow and all run correctly. I have not seen Acceptance Criteria in the #298 issue. I have seen comments on possible implementation, but as I understand at the moment this issue provides just the entries to 'alias' for both EVAL and REF. Is this sufficient?
I believe it is, as it needs to be combined with a separate PR on the ESMValTool repo to actually see any difference, but good to check with @alistairsellar or @ehogan. I'll ask for a second reviewer tomorrow. |
mo-nikosbaltas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will wait for comments by @alistairsellar and @ehogan and then I can approve.
Closes #298 .
PR creation checklist for the developer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the developer
docdirectory) related to the change been updated appropriately, including the Quick Start section?PR creation checklist for the reviewer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the reviewer
docdirectory) related to the change been updated appropriately, including the Quick Start section?