Convert filter multiple cubes from extract_cube to extract #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
Author
|
Looks like it has worked, and appears to work for a recipe I used that was failing due to this error requiring input fields A and B to calculate something (or at least produced a new error that will need fixing so will raise an issue for that shortly). I'm not sure if I have done exactly what you were aiming at, and am not convinced with the tests update. |
daflack
force-pushed
the
1791_extract_multiple_variables
branch
from
1ed092c to
c07110b
Compare
Switching to cube.extract() rather than cube.extract_cube() to enable multiple models to have derived diagnostics calculated. Fixes #1791
daflack
force-pushed
the
1791_extract_multiple_variables
branch
from
c07110b to
8175ecd
Compare
Document that filter_multiple_cubes can now produce multiple cubes per constraint, and fix a small typo in a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to
cube.extract()rather thancube.extract_cube()to enable multiple models to have derived diagnostics calculated.Fixes #1791
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.