Skip to content

Conversation

@james-bruten-mo
Copy link
Collaborator

@james-bruten-mo james-bruten-mo commented Dec 17, 2025

Respect the .gitignore when rsyncing local clones for the test suite. Not doing this is causing issues when the local build script has been run.
I've tested that this behaves as expected by running with the test suite from a clone with the local build output. The gitignore'd directories don't get copied. Also tested from /var/tmp to ensure it works for local filesystems.

@james-bruten-mo james-bruten-mo self-assigned this Dec 17, 2025
Copy link
Contributor

@t00sa t00sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@t00sa t00sa merged commit 31533b6 into MetOffice:main Dec 17, 2025
5 checks passed
@yaswant
Copy link
Collaborator

yaswant commented Dec 17, 2025

Its probably late, but including --exclude='.git/' in rsync can also be beneficial.
To combine both, rsync already has a build-in shorthand --cvs-exclude or -C to ignore files typically ignored by cvs (see man rsync) - this could be a bit aggressive though (you can test).

james-bruten-mo added a commit that referenced this pull request Dec 18, 2025
james-bruten-mo added a commit that referenced this pull request Dec 18, 2025
@james-bruten-mo james-bruten-mo mentioned this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants