Expand project scripts to work with issues too#187
Merged
james-bruten-mo merged 12 commits intoMetOffice:mainfrom Feb 17, 2026
Merged
Expand project scripts to work with issues too#187james-bruten-mo merged 12 commits intoMetOffice:mainfrom
james-bruten-mo merged 12 commits intoMetOffice:mainfrom
Conversation
| print_banner(f"Checking for closed pull requests not set to {milestone}") | ||
| total_other = 0 | ||
| for milestone in reviews.milestones: | ||
| if milestone == milestone: |
Collaborator
There was a problem hiding this comment.
Does this work? Surely you'll need a different variable name?
Collaborator
Author
There was a problem hiding this comment.
weirdly it does seem to, but I've changed it for clarity
|
|
||
| def remove_milestone( | ||
| issue_data: ProjectData, milestone: str, dry_run: bool = False | ||
| ) -> int: |
Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>
james-bruten-mo
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: @james-bruten-mo
Expand the current Project scripts to work with both the Issue and Pull requests, and expand the milestone script to also finish issues:
Also(!) add a new script for any project maintenance that happens at the CR deadline. Currently this just removes issues that don't have a linked PR from the milestone.
Code Quality Checklist
Testing
Security Considerations
AI Assistance and Attribution
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review