Skip to content

Local copy bug#192

Merged
jennyhickson merged 8 commits intoMetOffice:mainfrom
james-bruten-mo:local_copy_bug
Feb 17, 2026
Merged

Local copy bug#192
jennyhickson merged 8 commits intoMetOffice:mainfrom
james-bruten-mo:local_copy_bug

Conversation

@james-bruten-mo
Copy link
Collaborator

@james-bruten-mo james-bruten-mo commented Feb 17, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: @jennyhickson

Fixes an issue where mirrors were overwriting local clones when merging sources. If there is no ref when merging a source, this will raise an error.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

I've tested this with the UM standard suite, using a local git source with a branch

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

Comment on lines 198 to 199
"It is likely you desire a branch name which will always merge the "
"latest commits to a branch."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the second half of this sentence. Is it a description of the branch you should provide, or what will happen with that branch?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's not too clear - I've updated it...

@jennyhickson jennyhickson merged commit 1b842b3 into MetOffice:main Feb 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants