Adjust file types to be a set, making the inclusion of 'group' types trivial#193
Open
r-sharp wants to merge 3 commits intoMetOffice:mainfrom
Open
Adjust file types to be a set, making the inclusion of 'group' types trivial#193r-sharp wants to merge 3 commits intoMetOffice:mainfrom
r-sharp wants to merge 3 commits intoMetOffice:mainfrom
Conversation
…trivial e.g. the CI group to run tests equivalent to the CI stage on a PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @Pierre-siddall
Code Reviewer:
Subtle shit in the options for "file types" to store as a set which makes setting up "group" file -types, i.e. ones which resolve into multiple others, trivial.
I've added a demo one called CI, which will currently check Fortran and Python files.
Code Quality Checklist
Testing
I ran the umdp3 checker on it's containing branch.
The group filetype 'CI' corectly resolved to check "Fortran, Python" files
running pytest on the script_umdp3_checker directory returns no failures.
Security Considerations
AI Assistance and Attribution
GitHub CoPilot is turned on for "command completeion" when editing files. Some of the things it suggested were close enough to what was in my head that I accepted them.
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review