Refactor: Extract TabListItem from Tabs#2655
Merged
bgravenorst merged 3 commits intoMetaMask:mainfrom Feb 10, 2026
Merged
Conversation
|
@subhamkumarr is attempting to deploy a commit to the Consensys Team on Vercel. A member of the Team first needs to authorize it. |
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bgravenorst
approved these changes
Feb 10, 2026
Contributor
bgravenorst
left a comment
There was a problem hiding this comment.
Thanks for the contribution! lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the TODO in
src/theme/Tabs/index.tsxby extracting the inlineTabListIteminto a separate component.Changes
TabListItemfunction component withinsrc/theme/Tabs/index.tsx.<li>rendering logic and prop handling toTabListItem.TabListcomponent to renderTabListItem.Verification
npm run lintpasses without errors.npm run buildpasses (if applicable).Note
Refactors Tabs rendering and updates dependency overrides.
TabListIteminsrc/theme/Tabs/index.tsxand updatesTabListto render it; moves<li>props/handlers and ref management into the new componentoverridesinpackage.jsonforaxios@^1.7.9andcross-spawn@^7.0.6axios(to 1.13.2) and related deps (follow-redirects,form-data,proxy-from-env, etc.)Written by Cursor Bugbot for commit fbf62f3. This will update automatically on new commits. Configure here.