Skip to content

Comments

Refactor: Extract TabListItem from Tabs#2655

Merged
bgravenorst merged 3 commits intoMetaMask:mainfrom
subhamkumarr:refactor/extract-tablistitem
Feb 10, 2026
Merged

Refactor: Extract TabListItem from Tabs#2655
bgravenorst merged 3 commits intoMetaMask:mainfrom
subhamkumarr:refactor/extract-tablistitem

Conversation

@subhamkumarr
Copy link
Contributor

@subhamkumarr subhamkumarr commented Jan 27, 2026

Description

This PR addresses the TODO in src/theme/Tabs/index.tsx by extracting the inline TabListItem into a separate component.

Changes

  • Created TabListItem function component within src/theme/Tabs/index.tsx.
  • Moved <li> rendering logic and prop handling to TabListItem.
  • Simplified TabList component to render TabListItem.

Verification

  • npm run lint passes without errors.
  • npm run build passes (if applicable).
  • Manual verification: Tabs work as expected.

Note

Refactors Tabs rendering and updates dependency overrides.

  • Extracts TabListItem in src/theme/Tabs/index.tsx and updates TabList to render it; moves <li> props/handlers and ref management into the new component
  • Adds overrides in package.json for axios@^1.7.9 and cross-spawn@^7.0.6
  • Updates lockfile: upgrades axios (to 1.13.2) and related deps (follow-redirects, form-data, proxy-from-env, etc.)

Written by Cursor Bugbot for commit fbf62f3. This will update automatically on new commits. Configure here.

@subhamkumarr subhamkumarr requested review from a team as code owners January 27, 2026 19:19
@vercel
Copy link

vercel bot commented Jan 27, 2026

@subhamkumarr is attempting to deploy a commit to the Consensys Team on Vercel.

A member of the Team first needs to authorize it.

@socket-security
Copy link

socket-security bot commented Jan 27, 2026

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
metamask-docs Ready Ready Preview, Comment Feb 10, 2026 11:14pm

Request Review

Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! lgtm

@bgravenorst bgravenorst merged commit 401e332 into MetaMask:main Feb 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants