Skip to content

fix: remove hex amount leading zeros #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cryptotavares merged 2 commits into from
Nov 17, 2025
Merged

fix: remove hex amount leading zeros #419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4ab75b
fix: remove hex amount leading zeros
cryptotavares Nov 14, 2025
1f500ce
Merge branch 'main' into cryptotavares/fix-swap-comparison-amount-lea…
cryptotavares Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/components/transactions/swapComparison.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ const V4_BASE_ACTIONS_ABI_DEFINITION = {
};

// Helper functions for input validation and parsing
function stripLeadingZeros(hexString) {
// Handle 0x0 or 0x00...0 -> return 0x0
if (hexString === '0x' || /^0x0+$/u.test(hexString)) {
return '0x0';
}
// Remove leading zeros: 0x0110d... -> 0x110d...
return hexString.replace(/^0x0+/u, '0x');
}

function isValidAddress(address) {
return ethers.utils.isAddress(address);
}
Expand All @@ -58,8 +67,10 @@ function parseEthAmount(input) {
if (isNaN(parsed) || parsed < 0) {
return null;
}
// Convert ETH to wei and then to hex
return ethers.utils.parseEther(value.toString()).toHexString();
// Convert ETH to wei and then to hex, stripping leading zeros
return stripLeadingZeros(
ethers.utils.parseEther(value.toString()).toHexString(),
);
} catch {
return null;
}
Expand Down Expand Up @@ -104,7 +115,9 @@ function getConfigValues() {

const ethAmountHex =
parseEthAmount(ethAmountInput) ||
ethers.utils.parseEther(DEFAULT_ETH_AMOUNT).toHexString();
stripLeadingZeros(
ethers.utils.parseEther(DEFAULT_ETH_AMOUNT).toHexString(),
);

const feeBips =
parseFeePercentage(feePercentageInput) || DEFAULT_FEE_PERCENTAGE * 100;
Expand Down
Loading