fix(shellcheck): multios-usb.sh #54
Open
+42
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastien Varrette <sebastien.varrette@ssi.gouv.fr>
Mexit
reviewed
Feb 1, 2026
| else | ||
| OLDIFS=$IFS | ||
| IFS=. v1=($newVer) v2=($currVer) | ||
| IFS=. v1=("$newVer") v2=("$currVer") |
Owner
There was a problem hiding this comment.
I’m getting this error:
MultiOS-USB updater
./multios-usb.sh: line 214: [[: 0.11.5: syntax error: invalid arithmetic operator (error token is ".11.5")
./multios-usb.sh: line 217: [[: 0.11.5: syntax error: invalid arithmetic operator (error token is ".11.5")
Configuration is up to date
I think we should leave it unchanged.
Suggested change
| IFS=. v1=("$newVer") v2=("$currVer") | |
| IFS=. v1=($newVer) v2=($currVer) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix shellcheck warnings, simplify command checks