Add/update commands for gen5 #348
Merged
+1,495
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
Collaborator
kelvin-cao
left a comment
kelvin-cao
left a comment
There was a problem hiding this comment.
The commit message "Modify the argument -e to the tlp lcrc error injection. ..." suggests it's not a new command. Please remove.
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 26, 2025
kelvin-cao
reviewed
May 29, 2025
kelvin-cao
reviewed
May 29, 2025
kelvin-cao
reviewed
May 29, 2025
kelvin-cao
reviewed
May 29, 2025
kelvin-cao
reviewed
May 29, 2025
kelvin-cao
reviewed
May 29, 2025
kelvin-cao
reviewed
May 29, 2025
BenReed161
force-pushed
the
add-update-commands-to-gen5
branch
8 times, most recently
from
f36ce49 to
0190760
Compare
kelvin-cao
reviewed
Jun 5, 2025
kelvin-cao
reviewed
Jun 5, 2025
BenReed161
force-pushed
the
add-update-commands-to-gen5
branch
7 times, most recently
from
a41b6c9 to
86f255e
Compare
Update loopback set function sub command loopback type to follow the gen 5 spec. Add gen5 speed to list of supported loopback speeds in help message. Update the loopback code to add a new function to handle gen 5 loopback seperatly due to the changes compared to gen4. Added check for only gen4 args on a gen5 system. Added arguements for the parallel option and the external option and added additional information in the help option to show the arguement supports gen 4 / gen 5.
BenReed161
force-pushed
the
add-update-commands-to-gen5
branch
3 times, most recently
from
ef163d8 to
c91898a
Compare
Add the AER event generate commands in the diag library. This command allow the generation of AER events without the use of data. Update to support additional events, (prev. only supports the generation of error events associated with Corrected Error (CE).)
BenReed161
force-pushed
the
add-update-commands-to-gen5
branch
from
c91898a to
e7eb675
Compare
kelvin-cao
reviewed
Jun 10, 2025
kelvin-cao
reviewed
Jun 10, 2025
kelvin-cao
reviewed
Jun 10, 2025
Add new link error injection commands introduced with gen5 allows the user to inject a link error into a physical port. List of Errors: - DLLP - DLLP CRC - TLP LCRC - TLP seq num err - ACK/NAK err - Credit timeout err Include the inject header file for switchtec library to invoke the link inject error options.
Add support for Gen 5 for existing port eq commands. Port Equalization commands supported with the changes 1. port-eq-txcoeff 2. port-eq-txfslf 3. port-eq-txtable Change port eq txfslf to print the width of the current port instead of the negotiated link width to match tx coeff command for gen5. This change is to match the MRPC gen5 spec. (The -P (previous) equalization values are not currently supported in the Gen5 version due to firmware change requirement.)
BenReed161
force-pushed
the
add-update-commands-to-gen5
branch
3 times, most recently
from
8aa009f to
5f977aa
Compare
kelvin-cao
reviewed
Jun 10, 2025
BenReed161
force-pushed
the
add-update-commands-to-gen5
branch
from
5f977aa to
eafd518
Compare
Updated eye command gen5 mrpc. Add gen5 eye mrpc calls to original switchtec user eye command and added gen5 detection as part of the function. Added additional API function for calling the gen5 read functionality for reading the status since the gen5 eye observe has no output unlike gen4 to denote the status.
Add support for the MRPC pattern generator and monitor set/get commands. Sets the sub command ID to the correct version depending on gen. New command line arg with the pattern gen function for the link speed that the pattern generator command needs in the gen5 spec.
BenReed161
force-pushed
the
add-update-commands-to-gen5
branch
from
eafd518 to
f91084e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various commands updated to support gen 5, and added support for new commands introduced in gen5.
Updated:
New:
Note:
add support for gen5 pattern monitor / generatorcommit also includes a change to add theswitchtec_diag_loopback_set_gen5function toinc/switchtec/switchtec.h