Move samples repos Readme content into regular Docs#2069
Merged
captainbrosset merged 35 commits intomainfrom Sep 16, 2022
Merged
Move samples repos Readme content into regular Docs#2069captainbrosset merged 35 commits intomainfrom
captainbrosset merged 35 commits intomainfrom
Conversation
added 2 commits
July 20, 2022 18:35
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
captainbrosset
approved these changes
Aug 1, 2022
Contributor
captainbrosset
left a comment
There was a problem hiding this comment.
These changes look good to me.
JasonAndrewWriter
approved these changes
Aug 16, 2022
Contributor
JasonAndrewWriter
left a comment
There was a problem hiding this comment.
This was very clean. I hardly found anything.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
@nishitha-burman - please review and possibly approve this PR. @Reezaali @captainbrosset fyi/test msg
|
nishitha-burman
requested changes
Sep 14, 2022
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
As discussed with Michael offline, Nishitha has already approved this somewhere else. So I'll go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered pages for review, esp. the 3 nav pages: Getstart, Sample apps, & Deployment samples:
https://review.docs.microsoft.com/en-us/microsoft-edge/webview2/get-started/get-started?branch=pr-en-us-2069
Before:
https://docs.microsoft.com/en-us/microsoft-edge/webview2/get-started/get-started
Readmes in WebView2Samples repo:
PR 140: MicrosoftEdge/WebView2Samples#140
Before:
https://github.com/MicrosoftEdge/WebView2Samples/blob/main/README.md
Readme in WebView2Browser repo:
No PR
https://github.com/MicrosoftEdge/WebView2Browser/blob/main/README.md