Review the setup with docker compose #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
domi41
commented
May 29, 2025
domi41
commented
- dynamized some hardcoded values
- added some explanations
- commented out restic for now
- addded a core profile
- support for spaces in various env vars
- ignore some more files and document
- active reading in the README
- dynamized some hardcoded values - added some explanations - commented out restic for now - addded a core profile - support for spaces in various env vars - ignore some more files and document - active reading in the README
domi41
force-pushed
the
config-docker-compose-review
branch
from
ef29de8 to
6a29529
Compare
TheoSabattie
approved these changes
May 29, 2025
Contributor
TheoSabattie
left a comment
TheoSabattie
left a comment
There was a problem hiding this comment.
Top 👍 pourrais-tu faire un docker compose build & up sur le server pour t'assurer que tout tourne encore?
Contributor
Author
Ok ! Il faut faire un |
Contributor
|
Le déploiement n'est malheureusement pas automatique, il faut faire un git pull avant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.