perf: spatial hashing for InterestManagementBase#3380
Draft
Conversation
Contributor
Author
|
Oh, the interest management test setup does not play well with this (from memory):
So that would need improving too |
Contributor
Author
|
Ideally we'd just do a 1:1 non-breaking replacement for the normal spatial hashing here so users don't have to care, that should be doable? |
c1e04e6 to
561ca26
Compare
561ca26 to
01604a9
Compare
01604a9 to
3c5e363
Compare
3c5e363 to
7a356e7
Compare
7a356e7 to
338c063
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very much a work in progress and NEEDS changing before it is ready to merge (no runtime visibility changes and probably needs code cleaning up/commenting)
In my past testing, it's 4x faster for me
In @ninjakickja's recent testing ("simulation") it's 2.5x faster than the current one
Depends on/see #3379