Fix new line handling in crash logs #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, crash log files were not being processed at all due to incorrect line ending detection. The read_file() method failed to identify section markers when line endings differed from expected format. - Add get_line_ending() to preserve original line endings (CRLF/LF/CR) - Refactor read_file() to use splitlines(keepends=True) for proper parsing - Update add_name() to preserve line endings instead of forcing \n - Handle all line ending variants for PROBABLE CALL STACK and REGISTERS markers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, crash log files were not being processed at all due to incorrect newline detection. The read_file() method failed to identify section markers when line endings differed from expected format.