-
Notifications
You must be signed in to change notification settings - Fork 1
Implement test/claim/build submission #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
so, I chose args not modals becuase they actually have validated number input, but I think I used too few such that not being able to enter the existing values is a pain. build edit is fine, but claim edit should be split into map marker (with icon) and warp (without) same endpoint, just two commands |
|
Current implementation of the new |
|
Implementation redone, now it's nice. only the first 3 commands exist, and they include the metadata with them. I use "semi optional" arguments, where I check if platform has the data, and if it doesn't, only putting in some arguments is rejected. That way players will always enter their marker and warp with their claim, but they can edit it one field at a time, AND they get input validation. working: Discord_BtFHJJx4M5.mp4 |

Fixes #18
Fixes #19
Adds:
/submission test [submission]for uploading test lot images/submission claim [submission]for uploading claim images/submission build [submission]for uploading booth buildimages/submission update claim [submission]for changing marker and warp coordinates, plus icon/submission update booth [submission]for changing shard count, tourist eta, and completion statusDoes this implementation make any sense at all? Who knows!
I figured it best to implement it at any quality level and have it be corrected rather than have the feature potentially slip away - so have at it, feel free to approve as is or change it to suit your preferences (i just might be busy)