[fel] Refactor DefaultMcpClient: centralize request logic and improve robustness#143
Merged
CodeCasterX merged 1 commit intoModelEngine-Group:3.5.xfrom May 27, 2025
Conversation
…error handling, and enhance initialization robustness - Extracted common HTTP + JSON-RPC request logic into a reusable post2McpServer method to reduce duplication across ping, initialize, getTools, and callTool. - Introduced BiConsumer<HttpClassicClientRequest, Long> for custom per-method setup (e.g., session ID extraction, response handler registration). - Replaced polling loop in initialize() with explicit failure handling via IllegalStateException when initialization fails. - Used Event.ENDPOINT.code() instead of hardcoded "endpoint" for better type safety and maintainability. - Centralized and improved logging and exception handling; wrapped IO exceptions with contextual messages. - Added timeout support in waitInitialized() using wait(60_000L) to prevent indefinite waiting during initialization. - Simplified and unified RPC method calling pattern across the class. These changes increase code maintainability, improve error visibility, and make future enhancements easier.
CodeCasterX
added
type: enhancement
Yager-42
pushed a commit
to Yager-42/fit-framework
that referenced
this pull request
Aug 16, 2025
…error handling, and enhance initialization robustness (ModelEngine-Group#143) - Extracted common HTTP + JSON-RPC request logic into a reusable post2McpServer method to reduce duplication across ping, initialize, getTools, and callTool. - Introduced BiConsumer<HttpClassicClientRequest, Long> for custom per-method setup (e.g., session ID extraction, response handler registration). - Replaced polling loop in initialize() with explicit failure handling via IllegalStateException when initialization fails. - Used Event.ENDPOINT.code() instead of hardcoded "endpoint" for better type safety and maintainability. - Centralized and improved logging and exception handling; wrapped IO exceptions with contextual messages. - Added timeout support in waitInitialized() using wait(60_000L) to prevent indefinite waiting during initialization. - Simplified and unified RPC method calling pattern across the class. These changes increase code maintainability, improve error visibility, and make future enhancements easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes increase code maintainability, improve error visibility, and make future enhancements easier.