[fel] Add configurable ping interval#147
Merged
CodeCasterX merged 1 commit intoModelEngine-Group:3.5.xfrom May 29, 2025
Merged
Conversation
- Introduced configurable ping interval via constructor and configuration (application.yml) with a fallback default value (15,000 ms). - Moved ping scheduler creation to after initialization to ensure valid session state before sending pings. - Added parameter validation in DefaultMcpClient constructor using notNull and notBlank checks for better failure visibility. - Propagated ping interval configuration through DefaultMcpClientFactory using @value injection. - Improved testability and lifecycle management by decoupling scheduler setup from constructor logic. This change increases flexibility and robustness of the MCP client, especially in different deployment and test environments.
CodeCasterX
force-pushed
the
fel-enhancement-tool
branch
from
cf2ef5a to
cd07c0d
Compare
Yager-42
pushed a commit
to Yager-42/fit-framework
that referenced
this pull request
Aug 16, 2025
- Introduced configurable ping interval via constructor and configuration (application.yml) with a fallback default value (15,000 ms). - Moved ping scheduler creation to after initialization to ensure valid session state before sending pings. - Added parameter validation in DefaultMcpClient constructor using notNull and notBlank checks for better failure visibility. - Propagated ping interval configuration through DefaultMcpClientFactory using @value injection. - Improved testability and lifecycle management by decoupling scheduler setup from constructor logic. This change increases flexibility and robustness of the MCP client, especially in different deployment and test environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change increases flexibility and robustness of the MCP client, especially in different deployment and test environments.