Skip to content

[fel] polish code#215

Merged
CodeCasterX merged 1 commit into3.5.xfrom
fel-enhancement-cleanup
Jul 22, 2025
Merged

[fel] polish code#215
CodeCasterX merged 1 commit into3.5.xfrom
fel-enhancement-cleanup

Conversation

@loveTsong
Copy link
Contributor

@loveTsong loveTsong commented Jul 22, 2025

🔗 相关问题 / Related Issue

Issue 链接 / Issue Link: #

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改(如错别字),不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

📋 主要变更 / Brief Changelog

  • polish code

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更(微小变更如错别字除外)/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue,没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时,我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过:mvn -B clean package -Dmaven.test.skip=true,elsa README 中的编译检查 / Basic checks pass
  • 单元测试通过:mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更,我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes


审查者注意事项 / Reviewer Notes:

@loveTsong loveTsong added this to the 3.5.x milestone Jul 22, 2025
@loveTsong loveTsong requested a review from CodeCasterX July 22, 2025 01:59
@loveTsong loveTsong self-assigned this Jul 22, 2025
@loveTsong loveTsong added this to Nova Jul 22, 2025
@loveTsong loveTsong added type: enhancement A general enhancement in: fel Issues in FEL(FIT Expression for LLM) modules labels Jul 22, 2025
@CodeCasterX CodeCasterX modified the milestones: 3.5.x, 3.5.0 Jul 22, 2025
@loveTsong loveTsong force-pushed the fel-enhancement-cleanup branch from e395b0f to aacec48 Compare July 22, 2025 03:27
@loveTsong loveTsong force-pushed the fel-enhancement-cleanup branch from aacec48 to 02df13a Compare July 22, 2025 06:26
@CodeCasterX CodeCasterX merged commit 969ddbc into 3.5.x Jul 22, 2025
5 of 6 checks passed
@github-project-automation github-project-automation bot moved this to Done in Nova Jul 22, 2025
@CodeCasterX CodeCasterX deleted the fel-enhancement-cleanup branch July 22, 2025 06:41
relat-ivity added a commit to relat-ivity/fit-framework that referenced this pull request Sep 25, 2025
This reverts commit 969ddbc.

# Conflicts:
#	framework/fel/java/fel-core/src/main/java/modelengine/fel/core/document/support/postprocessor/RrfPostProcessor.java
#	framework/fel/java/fel-core/src/test/java/modelengine/fel/core/document/support/RerankModelStub.java
#	framework/fel/java/fel-core/src/test/java/modelengine/fel/core/document/support/TestRerankModelController.java
@relat-ivity relat-ivity mentioned this pull request Sep 25, 2025
27 tasks
CodeCasterX pushed a commit that referenced this pull request Sep 25, 2025
This reverts commit 969ddbc.

# Conflicts:
#	framework/fel/java/fel-core/src/main/java/modelengine/fel/core/document/support/postprocessor/RrfPostProcessor.java
#	framework/fel/java/fel-core/src/test/java/modelengine/fel/core/document/support/RerankModelStub.java
#	framework/fel/java/fel-core/src/test/java/modelengine/fel/core/document/support/TestRerankModelController.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: fel Issues in FEL(FIT Expression for LLM) modules type: enhancement A general enhancement

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants