Skip to content

[ohscript] 修改ohscript生成随机uuid方式提升性能 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeCasterX merged 4 commits into from
Apr 10, 2025
Merged

[ohscript] 修改ohscript生成随机uuid方式提升性能 #31

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbab0b0
[ohscript] 修改ohscript生成随机uuid方式
FUNK6666 Apr 2, 2025
4c6b221
[ohscript] 去除无效注释
FUNK6666 Apr 9, 2025
86d1fce
[ohscript] 优化初始化id锁粒度
FUNK6666 Apr 9, 2025
6b7daee
[ohscript] 修改檢視意見
FUNK6666 Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions framework/ohscript/src/main/java/modelengine/fit/ohscript/util/Tool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import modelengine.fit.ohscript.script.parser.nodes.FunctionDeclareNode;
import modelengine.fit.ohscript.script.semanticanalyzer.type.expressions.TypeExprFactory;
import modelengine.fitframework.beans.ObjectInstantiator;
import modelengine.fitframework.util.LockUtils;
import modelengine.fitframework.util.ObjectUtils;

import net.bytebuddy.ByteBuddy;
Expand All @@ -36,7 +37,9 @@
* @since 1.0
*/
public class Tool {
private static AtomicLong id = new AtomicLong(1); // remove static
private static final Object lock = LockUtils.newSynchronizedLock();

private static AtomicLong id = new AtomicLong(1);

/**
* 打印警告信息
Expand Down Expand Up @@ -73,9 +76,11 @@ protected static void setId(long value) {
/**
* 初始化id，只有在id为非正数时生效
*/
private static synchronized void initId() {
if (id.get() <= 0) {
setId(1);
private static void initId() {
synchronized (lock) {
if (id.get() <= 0) {
setId(1);
}
}
}

Expand All @@ -96,7 +101,7 @@ public static void grammarError(String info) {
* @return 返回生成的UUID
*/
public static String uuid() {
return UUIDUtil.fastUuid();
return String.valueOf(newId());
}

/**
Expand Down