This repository was archived by the owner on Mar 27, 2022. It is now read-only.
Set up OGP and support Twitter Card #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coord-e
suggested changes
Mar 1, 2019
public/index.html
Outdated
| <meta property="og:title" content="MonoMotion Robotics Framework" /> | ||
| <meta property="og:type" content="website" /> | ||
| <meta property="og:url" content="https://monomotion.netlify.com" /> | ||
| <meta property="og:image" content="https://monomotion.netlify.com/static/media/trainer.5ff8e856.png" /> |
Member
There was a problem hiding this comment.
this static image is generated by webpack and there is no guarantee that this image always exists.
We should add image directly in public/ and refer that image in ogp and twitter card
anharu2394
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
お願いします！