NOISSUE Add Install Legacy Fabric Button

[thecatcore]

To merge along side MultiMC/meta#9.
Closes #4408

[kb-1000]

I disagree with how this is done, you're making it confuse Fabric with Legacy Fabric.
They're not the same thing, and shouldn't be treated as such.
See #4408 (comment)

[thecatcore]

Is it really required when basically it installs upstream FabricLoader + Legacy Fabric Intermediary? 🤔

[PseudoDistant]

I disagree with how this is done, you're making it confuse Fabric with Legacy Fabric. They're not the same thing, and shouldn't be treated as such. See #4408 (comment)

They're not the same thing

Dude they use exactly the same loader, the only thing different is the intermediary file.

[jamierocks]

The button reads 'Install Fabric', now I would take that to mean Fabric - not a fork there-of.

This should be implemented as Quilt has just been, not by masquerading a third-party project as the upstream one.

[PseudoDistant]

@jamierocks you misunderstand.
It's not a fork, we literally use upstream Fabric Loader.
The only difference is the Intermediary being fed to it.

[jamierocks]

I don't misunderstand, I'm well aware of what Legacy Fabric is and isn't - and what Fabric is and isn't.

The button doesn't read 'Install Fabric Loader', it reads 'Install Fabric' - it currently does as I would expect and installs the Fabric Loader, and requires Fabric's intermediaries. These are part of the package that Fabric's installer would install, and together really form part of what most would consider Fabric.

Installing intermediaries from a third-party isn't what I would consider installing Fabric, it would be installing Legacy Fabric. Just because the package happens to use Fabric Loader, doesn't make the package what most would understand to be Fabric.

[thecatcore]

Updated accordingly to submitted suggestions.

[thecatcore]

oops fixed a typo...

[JFronny]

Forgive me if I read this wrong, but wouldn't it make more sense to not disable the button but hide it on newer versions and hide fabric on older ones?
Since neither will ever be available on versions where the other exists and they work as de-facto "equivalents" for another, adding a disabled button seems to me like unneeded clutter and this approach also avoids the problems mentioned by jamierocks.

[thecatcore]

How would I do it?

[ImperatorStorm]

Why was this closed?