[CLEANUP] Extract method DeclarationBlock::parseSelectors
#1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now does the selector-parsing that `parse()` used to do itself. Should help with #1324 and #1398 (comment)
JakeQZ
commented
Dec 9, 2025
| } | ||
|
|
||
| /** | ||
| * @param array<int, Comment> $comments |
Collaborator
Author
There was a problem hiding this comment.
I couldn't get Stan to be happy with list<Comment>...
Collaborator
There was a problem hiding this comment.
My best guess is that that's because ParserState::consumeUntil has $comments annotated as @param array<int, Comment> $comments as well, and it's passed by reference.
We probably can change both type annotations to list (in a separate PR).
Collaborator
Author
There was a problem hiding this comment.
Thanks. That is indeed the case.
We probably can change both type annotations to
list(in a separate PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now does the selector-parsing that
parse()used to do itself.Should help with #1324 and
#1398 (comment)