Skip to content

[CLEANUP] Extract method DeclarationBlock::parseSelector #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverklee merged 2 commits into from
Dec 12, 2025
Merged

[CLEANUP] Extract method DeclarationBlock::parseSelector #1420

oliverklee merged 2 commits into from
Dec 12, 2025

Conversation

@JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Dec 11, 2025

Closes #1324

@JakeQZ JakeQZ self-assigned this Dec 11, 2025
@JakeQZ JakeQZ added cleanup refactor For PRs that refactor code without changing functionality labels Dec 11, 2025
@JakeQZ JakeQZ marked this pull request as draft December 11, 2025 11:01
@coveralls
Copy link

coveralls commented Dec 11, 2025 •
edited
Loading

Coverage Status

coverage: 67.71% (+0.07%) from 67.642%
when pulling 3d66722 on cleanup/declarationblock-parseselector
into 1b1f91c on main.

@JakeQZ JakeQZ force-pushed the cleanup/declarationblock-parseselector branch from 26ac2f2 to f87f9e2 Compare December 11, 2025 21:35
@JakeQZ JakeQZ force-pushed the cleanup/declarationblock-parseselector branch from f87f9e2 to a14f582 Compare December 12, 2025 10:15
@JakeQZ JakeQZ marked this pull request as ready for review December 12, 2025 10:19
@JakeQZ JakeQZ requested a review from oliverklee December 12, 2025 10:19
oliverklee
oliverklee reviewed Dec 12, 2025
View reviewed changes
@JakeQZ @oliverklee
Add comment about fallthrough in switch
3d66722 
Co-authored-by: Oliver Klee <github@oliverklee.de>
@JakeQZ JakeQZ requested a review from oliverklee December 12, 2025 13:16
@oliverklee oliverklee merged commit a2c978c into main Dec 12, 2025
23 checks passed
@oliverklee oliverklee deleted the cleanup/declarationblock-parseselector branch December 12, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels

cleanup refactor For PRs that refactor code without changing functionality

Projects

None yet

Milestone

9.2.0: New features, bug fixes and de...

Development

Successfully merging this pull request may close these issues.

Refactor DeclarationBlock::parse()

4 participants

@JakeQZ @coveralls @oliverklee