Skip to content

Conversation

@oliverklee
Copy link
Collaborator

This makes our life as developers a bit more convenient.

Also run Rector before the style fixer as Rector is responsible for structural changes that need to be style-fixed after that.

This makes our life as developers a bit more convenient.

Also run Rector before the style fixer as Rector is responsible for
structural changes that need to be style-fixed after that.
@oliverklee oliverklee added enhancement developer-specific Issues that only affect maintainers, contributors, and people submitting PRs to-backport labels Nov 3, 2024
@oliverklee oliverklee requested a review from JakeQZ November 3, 2024 09:27
@oliverklee oliverklee self-assigned this Nov 3, 2024
@coveralls
Copy link

Coverage Status

coverage: 38.622%. remained the same
when pulling f542664 on task/fixers
into f6feb87 on main.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't yet have Composer-Normalize on this project, but the previous ordering within fix:php I think was correct, and should not be changed.

Comment on lines +92 to +93
"@fix:php:rector",
"@fix:php:fixer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F comes before R in the latin alphabet, so the existing ordering was correct.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this on purpose:

Also run Rector before the style fixer as Rector is responsible for structural changes that need to be style-fixed after that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this on purpose:

Also run Rector before the style fixer as Rector is responsible for structural changes that need to be style-fixed after that.

Sorry, I missed that, and for some reason thought the script content itself would be reordered by Composer-Normalize :/

Comment on lines +92 to +93
"@fix:php:rector",
"@fix:php:fixer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this on purpose:

Also run Rector before the style fixer as Rector is responsible for structural changes that need to be style-fixed after that.

Sorry, I missed that, and for some reason thought the script content itself would be reordered by Composer-Normalize :/

@JakeQZ JakeQZ merged commit d8154d3 into main Nov 4, 2024
21 checks passed
@JakeQZ JakeQZ deleted the task/fixers branch November 4, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer-specific Issues that only affect maintainers, contributors, and people submitting PRs enhancement to-backport

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants