[BUGFIX] Drop @covers annotation referencing inexistent method
#809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
bugfix/covers
branch
from
3eedc98 to
a768e95
Compare
JakeQZ
requested changes
Jan 26, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
The method definitely exists. The error is for some other reason. I don't know what.
The @covers annotation looks correct to me.
oliverklee
force-pushed
the
bugfix/covers
branch
from
a768e95 to
1b26da1
Compare
oliverklee
added a commit
that referenced
this pull request
Jan 26, 2025
According to the PHPUnit documentation [1], `@covers` annotations are only recommended to reference classes (and global functions), but not methods from classes. Also sort the `@covers` annotations. Note: This will probably artificially increase our calculated code coverage numbers until we migrate our tests to more focused unit tests. Closes #809 [1] https://docs.phpunit.de/en/8.5/annotations.html#covers
Collaborator
Author
|
As |
oliverklee
added a commit
that referenced
this pull request
Jan 26, 2025
According to the PHPUnit documentation [1], `@covers` annotations are only recommended to reference classes (and global functions), but not methods from classes. Also sort the `@covers` annotations. Note: This will probably artificially increase our calculated code coverage numbers until we migrate our tests to more focused unit tests. Closes #809 [1] https://docs.phpunit.de/en/8.5/annotations.html#covers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.