Skip to content

[TASK] Use native types for all constructor parameters #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oliverklee wants to merge 2 commits into from
Closed

[TASK] Use native types for all constructor parameters #818

oliverklee wants to merge 2 commits into from

Conversation

@oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Jan 26, 2025 •
edited
Loading

Part of #811

@oliverklee oliverklee added the blocked Needs another issue to be resolved first label Jan 26, 2025
@oliverklee oliverklee self-assigned this Jan 26, 2025
@oliverklee

This comment was marked as outdated.

Sign in to view
@oliverklee oliverklee mentioned this pull request Jan 26, 2025
Merged
@oliverklee oliverklee force-pushed the task/constructor-types branch 12 times, most recently from 410f2db to 3b1a8b8 Compare February 2, 2025 19:24
@oliverklee oliverklee force-pushed the task/constructor-types branch 8 times, most recently from 6a2518b to 2d5f721 Compare February 10, 2025 09:24
@oliverklee oliverklee force-pushed the task/constructor-types branch 5 times, most recently from c398bca to e54b7da Compare February 14, 2025 11:24
@oliverklee oliverklee force-pushed the task/constructor-types branch 7 times, most recently from 2f2e954 to 781bf29 Compare March 9, 2025 19:19
@oliverklee oliverklee force-pushed the task/constructor-types branch 17 times, most recently from e9dd90e to af1b661 Compare March 16, 2025 20:52
@coveralls
Copy link

coveralls commented Mar 16, 2025 •
edited
Loading

Coverage Status

coverage: 55.929%. remained the same
when pulling b7b0433 on task/constructor-types
into f9609c4 on main.

@oliverklee oliverklee force-pushed the task/constructor-types branch from af1b661 to b7b0433 Compare March 16, 2025 22:54
@oliverklee oliverklee closed this Mar 17, 2025
@oliverklee oliverklee deleted the task/constructor-types branch March 17, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oliverklee oliverklee

Labels

blocked Needs another issue to be resolved first

Projects

None yet

Milestone

9.0.0: Drop support for PHP < 7.2 and...

Development

Successfully merging this pull request may close these issues.

4 participants

@oliverklee @JakeQZ @coveralls