Skip to content

[TASK] Avoid using @covers annotations referencing methods #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakeQZ merged 1 commit into from
Jan 26, 2025
+19 −28
Merged

[TASK] Avoid using @covers annotations referencing methods #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions config/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,3 @@ parameters:
count: 2
path: ../src/RuleSet/DeclarationBlock.php

-
message: '#^@covers value \\Sabberworm\\CSS\\Value\\Value\:\:parseValue\(\) references an invalid method\.$#'
identifier: phpunit.coversMethod
count: 2
path: ../tests/ParserTest.php

23 changes: 10 additions & 13 deletions tests/ParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,17 @@
use Sabberworm\CSS\Value\URL;

/**
* @covers \Sabberworm\CSS\CSSList\Document
* @covers \Sabberworm\CSS\Parser
* @covers \Sabberworm\CSS\CSSList\Document::parse
* @covers \Sabberworm\CSS\Rule\Rule::parse
* @covers \Sabberworm\CSS\RuleSet\DeclarationBlock::parse
* @covers \Sabberworm\CSS\Value\CalcFunction::parse
* @covers \Sabberworm\CSS\Value\Color::parse
* @covers \Sabberworm\CSS\Value\CSSString::parse
* @covers \Sabberworm\CSS\Value\LineName::parse
* @covers \Sabberworm\CSS\Value\Size::parse
* @covers \Sabberworm\CSS\Value\URL::parse
* @covers \Sabberworm\CSS\RuleSet\DeclarationBlock
* @covers \Sabberworm\CSS\Rule\Rule
* @covers \Sabberworm\CSS\Value\CSSString
* @covers \Sabberworm\CSS\Value\CalcFunction
* @covers \Sabberworm\CSS\Value\Color
* @covers \Sabberworm\CSS\Value\LineName
* @covers \Sabberworm\CSS\Value\Size
* @covers \Sabberworm\CSS\Value\URL
* @covers \Sabberworm\CSS\Value\Value
Copy link
Collaborator

@JakeQZ JakeQZ Jan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional to add that it covers Value\Value?

Copy link
Collaborator Author

@oliverklee oliverklee Jan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as missingPropertyValueStrict and missingPropertyValueLenient had been marked as covering \Sabberworm\CSS\Value\Value::parseValue().

*/
final class ParserTest extends TestCase
{
Expand Down Expand Up @@ -971,8 +972,6 @@ public function unopenedClosingBracketFailure(): void
/**
* Ensure that a missing property value raises an exception.
*
* @covers \Sabberworm\CSS\Value\Value::parseValue()
*
* @test
*/
public function missingPropertyValueStrict(): void
Expand All @@ -985,8 +984,6 @@ public function missingPropertyValueStrict(): void
/**
* Ensure that a missing property value is ignored when in lenient parsing mode.
*
* @covers \Sabberworm\CSS\Value\Value::parseValue()
*
* @test
*/
public function missingPropertyValueLenient(): void
Expand Down
18 changes: 9 additions & 9 deletions tests/RuleSet/LenientParsingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
use Sabberworm\CSS\Settings;

/**
* @covers \Sabberworm\CSS\CSSList\Document
* @covers \Sabberworm\CSS\Parser
* @covers \Sabberworm\CSS\CSSList\Document::parse
* @covers \Sabberworm\CSS\Rule\Rule::parse
* @covers \Sabberworm\CSS\RuleSet\DeclarationBlock::parse
* @covers \Sabberworm\CSS\Value\CalcFunction::parse
* @covers \Sabberworm\CSS\Value\Color::parse
* @covers \Sabberworm\CSS\Value\CSSString::parse
* @covers \Sabberworm\CSS\Value\LineName::parse
* @covers \Sabberworm\CSS\Value\Size::parse
* @covers \Sabberworm\CSS\Value\URL::parse
* @covers \Sabberworm\CSS\RuleSet\DeclarationBlock
* @covers \Sabberworm\CSS\Rule\Rule
* @covers \Sabberworm\CSS\Value\CSSString
* @covers \Sabberworm\CSS\Value\CalcFunction
* @covers \Sabberworm\CSS\Value\Color
* @covers \Sabberworm\CSS\Value\LineName
* @covers \Sabberworm\CSS\Value\Size
* @covers \Sabberworm\CSS\Value\URL
*/
final class LenientParsingTest extends TestCase
{
Expand Down