Skip to content

Conversation

@mkelley
Copy link
Member

@mkelley mkelley commented Jan 7, 2026

Essentially distill Farnham, Schleicher, & A'Hearn 2000 into a fully-functional module:

  • Filter parameters (wavelengths, zero point flux density, solar color)
  • Continuum color and spectral slope
  • Afρ
  • Gas production rates
  • Gas decontamination
  • OH filter calibration using aerosol, Rayleigh, and ozone extinction

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the sbpy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label.
  • Is a milestone added?

@mkelley mkelley marked this pull request as draft January 7, 2026 18:58
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.11%. Comparing base (162139f) to head (9bfba05).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   84.72%   82.11%   -2.62%     
==========================================
  Files          92       55      -37     
  Lines        8459     4338    -4121     
==========================================
- Hits         7167     3562    -3605     
+ Misses       1292      776     -516     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkelley mkelley force-pushed the hb-filters-2026.01 branch from 6787c8a to 9bfba05 Compare January 12, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant