navbar update #7
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated 'should render title' test
* Adds Material tags Adds the dependency Angular Material and replaces the current tabs with Material style tags. * Remove Empty CSS Files * Test that only first tab's content is displayed * Remove hammerjs
Owner
|
@LDePriest Maybe you meant to update the branch you were working on? You probably want to rebase or fast forward. You don't need to do a PR for that, you can do it directly with git. Try something like |
Owner
|
@LDePriest Did you add stuff related to bootstrap? |
* Test not just first <p> * Add more tab tests
and fix style after rebase on prettier
Owner
|
What is bootstrap for? |
It still needs some work.
notably: * adds `npm run lints` to auto-format then run two linters * change the location of SMSInterface examples
The documentation output is marked in .gitignore for now. For tips on documenting using this tool see: https://dev.to/this-is-angular/documenting-angular-projects-5ob
Now VS Code only underlines format violations in blue! I'm not 100% sure what the change on .eslintrc line 43 does. Also made sure all lints pass.
Co-Authored-By: LDePriest <87504343+LDePriest@users.noreply.github.com>
Moved much of the code from consolodated viewer into xml-dom-display. The browser's native parsing tool is used instead of xml2js.
Now it only auto-updates only when it is being looked at or it hasn't been updated before.
Co-Authored-By: LDePriest <87504343+LDePriest@users.noreply.github.com>
Some changes don't do anything and are to prepare for future changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.