-
Notifications
You must be signed in to change notification settings - Fork 106
Complete the FATES-CLM nitrogen coupling #1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This renaming of variables corresponds to 116b310cd20f29bf5ca07b1d89f9e812f4e94477
| ! [kgC/plant/yr] -> [gC/m2/yr] | ||
| site_npp = site_npp + ccohort%npp_acc_hold * ccohort%n*area_inv * & | ||
| g_per_kg * hlm_days_per_year / sec_per_day | ||
| g_per_kg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
From meeting with @rgknox |
|
Ryan's update 2025/12/15: In our meeting 2025/12/16 Ryan offered to change the integer values (1 and 2) to strings. (I made the change from hardwired values to named params in the code.) |
This changes how we regulate root proportions, such that in CNP mode root proportions are not allowed to change while both N and P are supplementing. This was introduced by Bharat Sharma. slevis resolved conflicts: biogeochem/EDPhysiologyMod.F90 main/EDMainMod.F90 main/EDPftvarcon.F90 main/FatesInterfaceMod.F90
JSON formatted parameter files.
Description:
I started this PR with changes needed in ESCOMP/CTSM#3409.
So far that's just the renaming of
prt_carbon_allom_hyp to fates_c_only
prt_cnp_flex_allom_hyp to fates_cn
The corresponding ESCOMP issue:
ESCOMP/CTSM#3378
Resolves #1454
Collaborators:
@rgknox
@adrifoster
Expectation of Answer Changes:
I do not expect answers to change as a result of this PR alone; however, I expect answers to change for
fates_parteh_mode = 2as a result of the corresponding ESCOMP PR. So far I have not seen such diffs, while I have seen diffs forfates_parteh_mode = 1.Checklist
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: