Skip to content

[NRL-1700] Log info about which clientcert is being used for each req… #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattdean3-nhs merged 2 commits into from
Oct 24, 2025
Merged

[NRL-1700] Log info about which clientcert is being used for each req… #1071

mattdean3-nhs merged 2 commits into from
Oct 24, 2025

Conversation

@mattdean3-nhs
Copy link
Contributor

@mattdean3-nhs mattdean3-nhs commented Oct 15, 2025

…uest

@mattdean3-nhs mattdean3-nhs requested a review from a team as a code owner October 15, 2025 12:10
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

💥 Something went wrong while deploying the pull request environment.
Check Output Logs

@sandyforresternhs
Copy link
Contributor

sandyforresternhs commented Oct 15, 2025

Lgtm. I've given this a tick despite the PR deploy check having failed because I believe that's due to the certificate changes needing to be merged first in order for the check to pass. Suggest we rerun the check once the cert changes have merged.

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

🚀 PR environment successfully deployed.
Commit Hash: 71c8991d7e34a08c1c6f07370b7cdd377a01c0e8
URL: https://nrl1700-01ba47.api.record-locator.dev.national.nhs.uk/

@mattdean3-nhs mattdean3-nhs force-pushed the feature/made14-NRL-1700-log-clientcert-info branch from 71c8991 to 4dc6457 Compare October 22, 2025 15:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

🚀 PR environment successfully deployed.
Commit Hash: 4dc64573beb85e656df4b93a458339441493cdaf
URL: https://nrl1700-01ba47.api.record-locator.dev.national.nhs.uk/

@mattdean3-nhs mattdean3-nhs merged commit 7b6d4e6 into develop Oct 24, 2025
9 checks passed
@mattdean3-nhs mattdean3-nhs deleted the feature/made14-NRL-1700-log-clientcert-info branch October 24, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandyforresternhs sandyforresternhs sandyforresternhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattdean3-nhs @sandyforresternhs