NRL-519 validate context.practiceSetting as in NRL2.8 #750

katebobyn-nhs · 2024-11-22T15:59:55Z

No description provided.

github-actions · 2024-11-22T16:05:56Z

🚀 PR environment successfully deployed.
Commit Hash: 2c6ef7e24af24e25c6f83d16661dc29cf2ea4feb
URL: https://377204.api.record-locator.dev.national.nhs.uk/

…tting

github-actions · 2024-11-26T02:36:08Z

💥 Something went wrong while building the pull request environment.
Check Output Logs

github-actions · 2024-11-29T09:32:21Z

💥 Something went wrong while deploying the pull request environment.
Check Output Logs

github-actions · 2024-12-02T18:11:59Z

🚀 PR environment successfully deployed.
Commit Hash: aed5ca615954881a2846f98ad0cfcf45eb3f5c61
URL: https://377204.api.record-locator.dev.national.nhs.uk/

axelkrastek1-nhs

It's very good already, but could you fix the integration tests, sonarcloud issues and perhaps add some feature tests? 🥺

github-actions · 2024-12-04T17:56:34Z

🚀 PR environment successfully deployed.
Commit Hash: 9f44e028a1b8f52994d6d620fbf604a09f7d82c6
URL: https://377204.api.record-locator.dev.national.nhs.uk/

github-actions · 2024-12-04T19:14:47Z

🚀 PR environment successfully deployed.
Commit Hash: ef966237a58a0de17a79c6ab42aec4d212d34eca
URL: https://377204.api.record-locator.dev.national.nhs.uk/

github-actions · 2024-12-04T20:05:29Z

🚀 PR environment successfully deployed.
Commit Hash: dbde35db3a933ea97abaf95141e691f809592c33
URL: https://377204.api.record-locator.dev.national.nhs.uk/

…tting

github-actions · 2024-12-05T08:49:49Z

🚀 PR environment successfully deployed.
Commit Hash: 2aef83dd6026a5e9b343c935d0fb05c5fec4eb33
URL: https://377204.api.record-locator.dev.national.nhs.uk/

github-actions · 2024-12-05T08:56:29Z

🚀 PR environment successfully deployed.
Commit Hash: 4f6469475d50429c1b7c8d191d63c3433808d364
URL: https://377204.api.record-locator.dev.national.nhs.uk/

github-actions · 2024-12-05T09:09:23Z

🚀 PR environment successfully deployed.
Commit Hash: 8e4aa3e4eda079a1a7ae23cb2aa8c5f55516a715
URL: https://377204.api.record-locator.dev.national.nhs.uk/

github-actions · 2024-12-05T09:22:11Z

🚀 PR environment successfully deployed.
Commit Hash: c52fc09480985987be52b295daae2e1f9316d74e
URL: https://377204.api.record-locator.dev.national.nhs.uk/

sonarqubecloud · 2024-12-05T13:18:15Z

Quality Gate passed

Issues
0 New issues
6 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2024-12-05T13:23:37Z

🚀 PR environment successfully deployed.
Commit Hash: bfc1850a3c60e8c3c61e09f121ee903e290d3c7e
URL: https://377204.api.record-locator.dev.national.nhs.uk/

NRL-519 add practice setting codes from nrl2.8 to FHIR resources

2c6ef7e

katebobyn-nhs temporarily deployed to pull-request November 22, 2024 16:02 — with GitHub Actions Inactive

katebobyn-nhs temporarily deployed to pull-request November 22, 2024 16:06 — with GitHub Actions Inactive

katebobyn-nhs temporarily deployed to pull-request November 22, 2024 16:07 — with GitHub Actions Inactive

katebobyn-nhs and others added 2 commits November 26, 2024 02:29

NRL-519 add practice setting validator

8de586c

Merge branch 'develop' into feature/kabo5-NRL519-validate-practice-se…

ad5110e

…tting

NRL-519 add unit tests

aed5ca6

katebobyn-nhs marked this pull request as ready for review November 29, 2024 09:25

katebobyn-nhs had a problem deploying to pull-request November 29, 2024 09:28 — with GitHub Actions Failure

katebobyn-nhs temporarily deployed to pull-request December 2, 2024 18:08 — with GitHub Actions Inactive

katebobyn-nhs had a problem deploying to pull-request December 2, 2024 18:12 — with GitHub Actions Failure

axelkrastek1-nhs reviewed Dec 3, 2024

View reviewed changes

NRL-519 include practice setting in integration tests

9f44e02

katebobyn-nhs temporarily deployed to pull-request December 4, 2024 17:53 — with GitHub Actions Inactive

katebobyn-nhs had a problem deploying to pull-request December 4, 2024 17:56 — with GitHub Actions Failure

NRL-519 include practice setting in integration tests

ef96623

katebobyn-nhs temporarily deployed to pull-request December 4, 2024 19:12 — with GitHub Actions Inactive

katebobyn-nhs had a problem deploying to pull-request December 4, 2024 19:14 — with GitHub Actions Failure

NRL-519 include practice setting in integration tests

dbde35d

katebobyn-nhs temporarily deployed to pull-request December 4, 2024 20:02 — with GitHub Actions Inactive

katebobyn-nhs had a problem deploying to pull-request December 4, 2024 20:05 — with GitHub Actions Failure

NRL-519 include practice setting in integration tests

4b3ab85

katebobyn-nhs temporarily deployed to pull-request December 4, 2024 20:36 — with GitHub Actions Inactive

katebobyn-nhs and others added 2 commits December 5, 2024 08:44

NRL-519 add create failure scenarios for invalid practice settings

2aef83d

Merge branch 'develop' into feature/kabo5-NRL519-validate-practice-se…

39645c0

…tting

NRL-519 update smoketest to use a valid practiceSetting

4f64694

katebobyn-nhs changed the title ~~NRL-519 add practice setting codes from nrl2.8 to FHIR resources~~ NRL-519 validate context.practiceSetting as in NRL2.8 Dec 5, 2024

katebobyn-nhs temporarily deployed to pull-request December 5, 2024 08:54 — with GitHub Actions Inactive

katebobyn-nhs had a problem deploying to pull-request December 5, 2024 08:56 — with GitHub Actions Failure

NRL-519 fix confounding issue in create integration test

8e4aa3e

katebobyn-nhs temporarily deployed to pull-request December 5, 2024 09:07 — with GitHub Actions Inactive

katebobyn-nhs had a problem deploying to pull-request December 5, 2024 09:09 — with GitHub Actions Failure

NRL-519 fix formatting error

c52fc09

katebobyn-nhs temporarily deployed to pull-request December 5, 2024 09:19 — with GitHub Actions Inactive

katebobyn-nhs temporarily deployed to pull-request December 5, 2024 09:22 — with GitHub Actions Inactive

katebobyn-nhs temporarily deployed to pull-request December 5, 2024 09:24 — with GitHub Actions Inactive

katebobyn-nhs added 2 commits December 5, 2024 13:16

NRL-519 implement sonarcloud suggestions

b9f7d40

NRL-519 implement sonarcloud suggestions

bfc1850

katebobyn-nhs temporarily deployed to pull-request December 5, 2024 13:20 — with GitHub Actions Inactive

katebobyn-nhs temporarily deployed to pull-request December 5, 2024 13:23 — with GitHub Actions Inactive

katebobyn-nhs temporarily deployed to pull-request December 5, 2024 13:25 — with GitHub Actions Inactive

eesa456 approved these changes Dec 6, 2024

View reviewed changes

eesa456 merged commit ed9fd52 into develop Dec 9, 2024
8 checks passed

eesa456 deleted the feature/kabo5-NRL519-validate-practice-setting branch December 9, 2024 09:45

eesa456 temporarily deployed to pull-request December 9, 2024 09:45 — with GitHub Actions Inactive

NRL-519 validate context.practiceSetting as in NRL2.8 #750

NRL-519 validate context.practiceSetting as in NRL2.8 #750

Uh oh!

Conversation

katebobyn-nhs commented Nov 22, 2024

Uh oh!

github-actions bot commented Nov 22, 2024

Uh oh!

github-actions bot commented Nov 26, 2024

Uh oh!

github-actions bot commented Nov 29, 2024

Uh oh!

github-actions bot commented Dec 2, 2024

Uh oh!

axelkrastek1-nhs left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 4, 2024

Uh oh!

github-actions bot commented Dec 4, 2024

Uh oh!

github-actions bot commented Dec 4, 2024

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

sonarqubecloud bot commented Dec 5, 2024

Quality Gate passed

Uh oh!

github-actions bot commented Dec 5, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

axelkrastek1-nhs left a comment •

edited

Loading