Skip to content

Conversation

@mattdean3-nhs
Copy link
Contributor

No description provided.

@sonarqubecloud
Copy link

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: a95f144698a79803ce1080588e68cdd5f641f886
URL: https://nrl1228-bbbb9b.api.record-locator.dev.national.nhs.uk/

@katebobyn-nhs katebobyn-nhs merged commit 309c88a into develop Dec 12, 2024
8 checks passed
@katebobyn-nhs katebobyn-nhs deleted the bugfix/made14-NRL-1228-advance-care-plans branch December 12, 2024 16:32
Copy link
Contributor

@axelkrastek1-nhs axelkrastek1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but we need to apply those changes in the proxy schema as well, and also sonarcloud warnings need fixing.

raise Exception("Failed to validate document: " + str(result.issues))


def _find_invalid_pointers(table_name: str) -> dict[str, float]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

Suggested change
def _find_invalid_pointers(table_name: str) -> dict[str, float]:
def _find_invalid_pointers(table_name: str) -> dict[str, float | int]:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants