NRL-1076 add integration and unit tests for accession number #771

eesa456 · 2024-12-13T07:08:43Z

…er and error message fix

github-actions · 2024-12-13T07:10:44Z

💥 Something went wrong while building the pull request environment.
Check Output Logs

github-actions · 2024-12-13T07:23:04Z

🚀 PR environment successfully deployed.
Commit Hash: 4abb3e3724ccce686c68812c02021eb52615f301
URL: https://nrl1076-e84289.api.record-locator.dev.national.nhs.uk/

axelkrastek1-nhs · 2024-12-13T09:01:08Z

tests/features/consumer/searchDocumentReference-failure.feature

+    When consumer 'RX898' searches for DocumentReferences with parameters:
+      | parameter | value                                   |
+      | subject   | 9278693472                              |
+      | type      | http://snomed.info/sct\|887701000000100 |


This might not be doing what you expect it to do. See:

NRLF/tests/features/utils/data.py

Line 66 in 309c88a

if type_code := items.get("type"):

I'm searching for pointers with that type as a parameter thats got nothing to do with creating a pointer of a certain type?

True, it's a search, ignore me

axelkrastek1-nhs · 2024-12-13T09:05:12Z

tests/features/consumer/searchPostDocumentReference-failure.feature

+    When consumer 'RX898' searches for DocumentReferences using POST with request body:
+      | key     | value                                   |
+      | subject | 9278693472                              |
+      | type    | http://snomed.info/sct\|887701000000100 |


Same as above, see:

NRLF/tests/features/utils/data.py

Line 66 in 309c88a

if type_code := items.get("type"):

yeah its a parameter for the search request not creating a pointer

True, it's a search, ignore me

github-actions · 2024-12-13T09:53:16Z

🚀 PR environment successfully deployed.
Commit Hash: 1754771ae617e936e67824a6bd239b4487ce4e9b
URL: https://nrl1076-e84289.api.record-locator.dev.national.nhs.uk/

github-actions · 2024-12-13T10:18:11Z

🚀 PR environment successfully deployed.
Commit Hash: 1754771ae617e936e67824a6bd239b4487ce4e9b
URL: https://nrl1076-e84289.api.record-locator.dev.national.nhs.uk/

github-actions · 2024-12-13T10:47:33Z

🚀 PR environment successfully deployed.
Commit Hash: 123f8379b53a5c5f1384e92dd60164f470df3cff
URL: https://nrl1076-e84289.api.record-locator.dev.national.nhs.uk/

axelkrastek1-nhs · 2024-12-13T10:50:27Z

tests/features/consumer/searchDocumentReference-failure.feature

+    When consumer 'RX898' searches for DocumentReferences with parameters:
+      | parameter | value                                   |
+      | subject   | 9278693472                              |
+      | type      | http://snomed.info/sct\|887701000000100 |


True, it's a search, ignore me

axelkrastek1-nhs · 2024-12-13T10:50:32Z

tests/features/consumer/searchPostDocumentReference-failure.feature

+    When consumer 'RX898' searches for DocumentReferences using POST with request body:
+      | key     | value                                   |
+      | subject | 9278693472                              |
+      | type    | http://snomed.info/sct\|887701000000100 |


True, it's a search, ignore me

github-actions · 2024-12-13T11:07:52Z

🚀 PR environment successfully deployed.
Commit Hash: 123f8379b53a5c5f1384e92dd60164f470df3cff
URL: https://nrl1076-e84289.api.record-locator.dev.national.nhs.uk/

NRL-1076-IdentifyLinkedStudiesAndReports

github-actions · 2024-12-13T12:09:14Z

🚀 PR environment successfully deployed.
Commit Hash: 9c16a6c97e11f62b35921d0d3be83917c5dba166
URL: https://nrl1076-e84289.api.record-locator.dev.national.nhs.uk/

NRL-1076-IdentifyLinkedStudiesAndReports

sonarqubecloud · 2024-12-13T15:38:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2024-12-13T15:43:16Z

🚀 PR environment successfully deployed.
Commit Hash: 19ad61573a18c25f42fda27a07cdf8cba432c0c8
URL: https://nrl1076-e84289.api.record-locator.dev.national.nhs.uk/

NRL-1076 add integration and unit tests for identifier accession numb…

d946923

…er and error message fix

eesa456 changed the title ~~NRL-1076 add integration and unit tests for identifier accession numb…~~ NRL-1076 add integration and unit tests for accession number Dec 13, 2024

NRL-1076 fix tests

4abb3e3

eesa456 temporarily deployed to pull-request December 13, 2024 07:19 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 13, 2024 07:23 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 13, 2024 07:25 — with GitHub Actions Inactive

axelkrastek1-nhs reviewed Dec 13, 2024

View reviewed changes

NRL-1202 standardise message

1754771

eesa456 temporarily deployed to pull-request December 13, 2024 09:49 — with GitHub Actions Inactive

eesa456 had a problem deploying to pull-request December 13, 2024 09:53 — with GitHub Actions Failure

eesa456 temporarily deployed to pull-request December 13, 2024 10:16 — with GitHub Actions Inactive

eesa456 had a problem deploying to pull-request December 13, 2024 10:18 — with GitHub Actions Failure

NRL-1202 fix int tests

123f837

eesa456 temporarily deployed to pull-request December 13, 2024 10:45 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 13, 2024 10:47 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 13, 2024 10:49 — with GitHub Actions Inactive

eesa456 had a problem deploying to pull-request December 13, 2024 10:49 — with GitHub Actions Failure

axelkrastek1-nhs approved these changes Dec 13, 2024

View reviewed changes

eesa456 temporarily deployed to pull-request December 13, 2024 11:04 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 13, 2024 11:08 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 13, 2024 11:09 — with GitHub Actions Inactive

Merge branch 'develop' of github.com:NHSDigital/NRLF into feature/eema1-

9c16a6c

NRL-1076-IdentifyLinkedStudiesAndReports

eesa456 temporarily deployed to pull-request December 13, 2024 12:05 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 13, 2024 12:09 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 13, 2024 12:11 — with GitHub Actions Inactive

eesa456 had a problem deploying to pull-request December 13, 2024 12:11 — with GitHub Actions Failure

Merge branch 'develop' of github.com:NHSDigital/NRLF into feature/eema1-

19ad615

NRL-1076-IdentifyLinkedStudiesAndReports

eesa456 temporarily deployed to pull-request December 13, 2024 15:40 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 13, 2024 15:43 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 13, 2024 15:45 — with GitHub Actions Inactive

eesa456 merged commit 32d461f into develop Dec 13, 2024
8 checks passed

eesa456 deleted the feature/eema1-NRL-1076-IdentifyLinkedStudiesAndReports branch December 13, 2024 15:51

eesa456 temporarily deployed to pull-request December 13, 2024 15:51 — with GitHub Actions Inactive

NRL-1076 add integration and unit tests for accession number #771

NRL-1076 add integration and unit tests for accession number #771

Uh oh!

Conversation

eesa456 commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

sonarqubecloud bot commented Dec 13, 2024

Quality Gate passed

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants