Skip to content

[NRL-1228] Fixup sonar cloud warnings #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdean3-nhs merged 1 commit into from
Dec 13, 2024
Merged

[NRL-1228] Fixup sonar cloud warnings #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions reports/find_invalid_pointers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ def _validate_document(document: str):
result = validator.validate(data=docref)

if not result.is_valid:
raise Exception("Failed to validate document: " + str(result.issues))
raise RuntimeError("Failed to validate document: " + str(result.issues))


def _find_invalid_pointers(table_name: str) -> dict[str, float]:
def _find_invalid_pointers(table_name: str) -> dict[str, float | int]:
"""
Find pointers in the given table that are invalid.
Parameters:
Expand All @@ -45,12 +45,12 @@ def _find_invalid_pointers(table_name: str) -> dict[str, float]:

for page in paginator.paginate(**params):
for item in page["Items"]:
id = item.get("id", {}).get("S")
pointer_id = item.get("id", {}).get("S")
document = item.get("document", {}).get("S", "")
try:
_validate_document(document)
except Exception as exc:
invalid_pointers.append((id, exc))
invalid_pointers.append((pointer_id, exc))

total_scanned_count += page["ScannedCount"]

Expand All @@ -64,12 +64,13 @@ def _find_invalid_pointers(table_name: str) -> dict[str, float]:

end_time = datetime.now(tz=timezone.utc)

print(" Done") # noqa

print("Writing invalid_pointers to file ./invalid_pointers.txt ...") # noqa
with open("invalid_pointers.txt", "w") as f:
for id, err in invalid_pointers:
f.write(f"{id}: {err}\n")
for _id, err in invalid_pointers:
f.write(f"{_id}: {err}\n")

print(" Done") # noqa
return {
"invalid_pointers": len(invalid_pointers),
"scanned_count": total_scanned_count,
Expand Down