Skip to content

[NRL-1231] Fixup counter issue in delete_all_invalid_pointers.py script #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eesa456 merged 2 commits into from
Dec 19, 2024
Merged

[NRL-1231] Fixup counter issue in delete_all_invalid_pointers.py script #780

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23acc87
[NRL-1231] Fixup counter issue in delete_all_invalid_pointers.py script
mattdean3-nhs Dec 18, 2024
8d7a7df
Merge branch 'develop' into feature/made14-NRL-1231-delete-invalid-po…
eesa456 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/delete_all_invalid_pointers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def _delete_pointers(table_name: str, pointers_to_delete: list[str]) -> dict[str
result = dynamodb.batch_write_item(RequestItems={table_name: batch})

unprocessed_items = len(result.get("UnprocessedItems", []))
pointers_deleted += 25 - unprocessed_items
pointers_deleted += len(batch) - unprocessed_items
failed_to_delete += unprocessed_items
if pointers_deleted % 1000 == 0:
print(".", end="", flush=True)
Expand Down
Loading