Skip to content

NRL-523 delete response is 200 for no pointer found #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eesa456 merged 2 commits into from
Apr 25, 2025
Merged

NRL-523 delete response is 200 for no pointer found #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79cc8b4
NRL-523 return a 200 for when no pointer is found for given ID
eesa456 Apr 15, 2025
162118f
NRL-523 update feature tests
eesa456 Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions api/producer/deleteDocumentReference/delete_document_reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@ def handler(

if not (core_model := repository.get_by_id(pointer_id)):
logger.log(LogReference.PRODELETE002, pointer_id=pointer_id)
return SpineErrorResponse.NO_RECORD_FOUND(
diagnostics="The requested DocumentReference could not be found",
)
return NRLResponse.RESOURCE_DOES_NOT_EXIST_DELETE()

repository.delete(core_model)

Expand Down
12 changes: 6 additions & 6 deletions api/producer/deleteDocumentReference/tests/test_delete_document_reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def test_delete_document_reference_not_exists(repository: DocumentPointerReposit
body = result.pop("body")

assert result == {
"statusCode": "404",
"statusCode": "200",
"headers": default_response_headers(),
"isBase64Encoded": False,
}
Expand All @@ -150,14 +150,14 @@ def test_delete_document_reference_not_exists(repository: DocumentPointerReposit
"resourceType": "OperationOutcome",
"issue": [
{
"severity": "error",
"code": "not-found",
"severity": "information",
"code": "informational",
"details": {
"coding": [
{
"code": "NO_RECORD_FOUND",
"display": "No record found",
"system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
"code": "RESOURCE_DELETED",
"display": "Resource deleted",
"system": "https://fhir.nhs.uk/ValueSet/NRL-ResponseCode",
}
]
},
Expand Down
14 changes: 14 additions & 0 deletions layer/nrlf/core/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,20 @@ def RESOURCE_DELETED(cls):
statusCode="200",
)

@classmethod
def RESOURCE_DOES_NOT_EXIST_DELETE(cls):
Copy link
Contributor Author

@eesa456 eesa456 Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can alter this however people feel, if we want the diagnostics to say its already deleted or something else thats cool too

return cls.from_issues(
issues=[
producer_model.OperationOutcomeIssue(
severity="information",
code="informational",
details=NRLResponseConcept.from_code("RESOURCE_DELETED"),
diagnostics="The requested DocumentReference could not be found",
)
],
statusCode="200",
)


class SpineErrorResponse(Response):
@classmethod
Expand Down
12 changes: 6 additions & 6 deletions tests/features/producer/deleteDocumentReference-success.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,19 +48,19 @@ Feature: Producer - deleteDocumentReference - Success Scenarios
| system | value |
| http://snomed.info/sct | 736253002 |
When producer 'DK94' requests to delete DocumentReference with id 'DK94-000-NoPointerHere'
Then the response status code is 404
Then the response status code is 200
And the response is an OperationOutcome with 1 issue
And the OperationOutcome contains the issue:
"""
{
"severity": "error",
"code": "not-found",
"severity": "information",
"code": "informational",
"details": {
"coding": [
{
"system": "https://fhir.nhs.uk/ValueSet/Spine-ErrorOrWarningCode-1",
"code": "NO_RECORD_FOUND",
"display": "No record found"
"system": "https://fhir.nhs.uk/ValueSet/NRL-ResponseCode",
"code": "RESOURCE_DELETED",
"display": "Resource deleted"
}
]
},
Expand Down