Skip to content

NRL-1386 Add infra and config for prod dashboards #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattdean3-nhs merged 29 commits into from
Jun 30, 2025
Merged

NRL-1386 Add infra and config for prod dashboards #937

mattdean3-nhs merged 29 commits into from
Jun 30, 2025

Conversation

@mattdean3-nhs
Copy link
Contributor

@mattdean3-nhs mattdean3-nhs commented Jun 18, 2025

Main points to call out:

  • Resources for reporting, like athena and glue, are now provisioned once for each AWS account
  • TF var added to allow active reporting services (like glue and EC2) to be enabled/disabled account-wide
  • Reporting source bucket is no longer versioned - to fix messy S3 lifecycle delete-marker issues
  • Firehose streams are no longer created in ephemeral envs
  • Fixed state issues with API gateway 403 responses

jackleary and others added 16 commits June 9, 2025 15:31
@jackleary
NRL-1479 update firehose buffer time for quicker testing
c3c803a
@jackleary
NRL-1479 update logging set up
aca8513
@jackleary
NRL-1479 Update logging
67152e7
@jackleary
NRL-1479 Update iam role to allow notebooks to run
da6b10d
@jackleary
NRL-1479 Update logging and lower all columns before writing to parquet
2c6322c
@mattdean3-nhs
[NRL-1386] Add reporting infra to all envs
cfa08a5
@jackleary
NRL-1479 Add views as saved queries
7a34959
@jackleary
NRL-1479 Add athena views to deployment
9cf8f54
@mattdean3-nhs
[NRL-1386] Rename ec2 module, add toggle for powerbi gw deploy.
53acc81
@mattdean3-nhs
Merge remote-tracking branch 'origin/feature/jale13-NRL-1479-temp-cha…
e72cc3a 
…nges' into feature/made14-NRL-1386-prod-dashboards-infra
@mattdean3-nhs
[NRL-1386] Revert unwanted firehose buffering change
8cdf238
@mattdean3-nhs
[NRL-1386] WIP Fixup powerbi gw TF prov issues
910dd30
@mattdean3-nhs
[NRL-1386] Add missing glue_database to test+prod. Fix TF apply state…
0e8116a 
… issues
@mattdean3-nhs
[NRL-1386] Fix glue source bucket lifecycle auto-deletes
b25f569
@mattdean3-nhs
[NRL-1386] Add var to enable/disable all reporting services per env a…
950d036 
…nd account-wide
@mattdean3-nhs
[NRL-1386] Don't provision infra firehose streams for ephem envs
e73a0c6
mattdean3-nhs
mattdean3-nhs commented Jun 18, 2025
View reviewed changes
mattdean3-nhs
mattdean3-nhs commented Jun 18, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jun 18, 2025

🚀 PR environment successfully deployed.
Commit Hash: e73a0c658d24bd3c25740a4ae414c7620c2fc99e
URL: https://nrl1386-758036.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

github-actions bot commented Jun 26, 2025

🚀 PR environment successfully deployed.
Commit Hash: 37005d4d12b71454a71b6321ebbd8c7d5f98cc4b
URL: https://nrl1386-758036.api.record-locator.dev.national.nhs.uk/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

github-actions bot commented Jun 27, 2025

🚀 PR environment successfully deployed.
Commit Hash: 02eff29a34127c42872779b09a9bdfcacd4eb719
URL: https://nrl1386-758036.api.record-locator.dev.national.nhs.uk/

@mattdean3-nhs mattdean3-nhs merged commit bdc0a14 into develop Jun 30, 2025
15 checks passed
@mattdean3-nhs mattdean3-nhs deleted the feature/made14-NRL-1386-prod-dashboards-infra branch June 30, 2025 08:51
@github-actions
Copy link

github-actions bot commented Jun 30, 2025

💥 Something went wrong while destroying the pull request environment.
Check Output Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axelkrastek1-nhs axelkrastek1-nhs axelkrastek1-nhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattdean3-nhs @axelkrastek1-nhs @jackleary