[GPDAPIM-258] SDS access module #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Image Scan SummaryImage: 900119715266.dkr.ecr.eu-west-2.amazonaws.com/whoami:feature-gpcapim-258-sds-access-module
Findings (top 50)
|
DWolfsNHS
reviewed
Feb 10, 2026
DWolfsNHS
reviewed
Feb 10, 2026
DWolfsNHS
reviewed
Feb 10, 2026
DWolfsNHS
reviewed
Feb 10, 2026
|
✅ Trivy gate: no Critical/High issues. Trivy IaC (Terraform) Summary
Findings (top 50)
|
DWolfsNHS
reviewed
Feb 11, 2026
DWolfsNHS
reviewed
Feb 11, 2026
Comment on lines
+84
to
+88
| # FHIR identifier systems | ||
| ODS_SYSTEM = "https://fhir.nhs.uk/Id/ods-organization-code" | ||
| INTERACTION_SYSTEM = "https://fhir.nhs.uk/Id/nhsServiceInteractionId" | ||
| PARTYKEY_SYSTEM = "https://fhir.nhs.uk/Id/nhsMhsPartyKey" | ||
| ASID_SYSTEM = "https://fhir.nhs.uk/Id/nhsSpineASID" |
Collaborator
There was a problem hiding this comment.
Fine in the context of this PR, but I wonder if these might be in a common FHIR config long-term. @davidhamill1-nhs might have an approach in the harmonisation ticket.
DWolfsNHS
reviewed
Feb 11, 2026
Comment on lines
+78
to
+82
| # URLs for different SDS environments | ||
| SANDBOX_URL = "https://sandbox.api.service.nhs.uk/spine-directory/FHIR/R4" | ||
| INT_URL = "https://int.api.service.nhs.uk/spine-directory/FHIR/R4" | ||
| DEP_UAT_URL = "https://dep.api.service.nhs.uk/spine-directory/FHIR/R4" | ||
| PROD_URL = "https://api.service.nhs.uk/spine-directory/FHIR/R4" |
Collaborator
There was a problem hiding this comment.
I can see that these might be useful long-term, but are they adding value at this point?
DWolfsNHS
reviewed
Feb 11, 2026
Comment on lines
+94
to
+97
| # Default service interaction ID for GP Connect | ||
| DEFAULT_SERVICE_INTERACTION_ID = ( | ||
| "urn:nhs:names:services:gpconnect:fhir:rest:read:metadata-1" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Our scope for Alpha is specifically ARS so makes sense to use it now. As GPC has other interactionIDs though it's probably worth being explict.
Suggested change
| # Default service interaction ID for GP Connect | |
| DEFAULT_SERVICE_INTERACTION_ID = ( | |
| "urn:nhs:names:services:gpconnect:fhir:rest:read:metadata-1" | |
| ) | |
| # Default service interaction ID for GP Connect | |
| ACCESS_RECORD_STRUCTURED_INTERACTION_ID = ( | |
| "urn:nhs:names:services:gpconnect:fhir:operation:gpc.getstructuredrecord-1 | |
| ) |
|
|
Deployment Complete
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates the SDS access module and integrates it with the controller.
Context
CDG requires the ability to obtain organisation ASIDs and endpoints from SDS. This provides that capability.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.