Skip to content

Conversation

@will-larkin-nhs
Copy link
Contributor

Description

Changes the data services core tests to use the real DataServicesContext instead of a test one

Context

trying to inject a fake DbContext for testing caused a bug

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link

github-actions bot commented May 30, 2025

Unit Test Results

❌ Tests 823 / 843 (20 failed, 0 skipped) - failed in 68.6s
📝 Coverage 58.43%
📏 4558 / 7648 lines covered 🌿 1071 / 1986 branches covered
🔍 click here for more details

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2025

@Warren-Pitterson Warren-Pitterson deleted the data-services-tests-fix branch September 10, 2025 15:23
@Warren-Pitterson Warren-Pitterson restored the data-services-tests-fix branch September 10, 2025 15:24
@Warren-Pitterson Warren-Pitterson deleted the data-services-tests-fix branch September 10, 2025 15:24
@will-larkin-nhs will-larkin-nhs restored the data-services-tests-fix branch September 11, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants