Skip to content

feat: replaced DefaultAzureCredential with ManagedIdentityCredential #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Warren-Pitterson wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: replaced DefaultAzureCredential with ManagedIdentityCredential #1795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75b912e
feat: replaced DefaultAzureCredential with ManagedIdentityCredential
Warren-Pitterson Dec 18, 2025
f1f6d7c
Merge branch 'main' into feat/DTOSS-9903-ManagedIdentity-Azure
Warren-Pitterson Dec 19, 2025
f3f5dc6
Merge branch 'main' into feat/DTOSS-9903-ManagedIdentity-Azure
Warren-Pitterson Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions application/CohortManager/src/Functions/CaasIntegration/RetrieveMeshFile/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
{
// Get CohortManager private key
logger.LogInformation("Pulling Mesh Certificate from KeyVault");
var certClient = new CertificateClient(vaultUri: new Uri(config.KeyVaultConnectionString), credential: new DefaultAzureCredential());
var certClient = new CertificateClient(vaultUri: new Uri(config.KeyVaultConnectionString), credential: new ManagedIdentityCredential ());
var certificate = await certClient.DownloadCertificateAsync(config.MeshKeyName);
cohortManagerPrivateKey = certificate.Value;

// Get MESH public certificates (CA chain)
var secretClient = new SecretClient(vaultUri: new Uri(config.KeyVaultConnectionString), credential: new DefaultAzureCredential());
var secretClient = new SecretClient(vaultUri: new Uri(config.KeyVaultConnectionString), credential: new ManagedIdentityCredential ());
string base64Cert = (await secretClient.GetSecretAsync(config.MeshCertName)).Value.Value;
meshCerts = CertificateHelper.GetCertificatesFromString(base64Cert);
}
Expand Down Expand Up @@ -82,4 +82,3 @@
logger.LogCritical(ex, "Failed to start up Function");
}


4 changes: 2 additions & 2 deletions application/CohortManager/src/Functions/NemsSubscriptionService/NemsMeshRetrieval/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
{
// Get CohortManager private key
logger.LogInformation("Pulling Mesh Certificate from KeyVault");
var certClient = new CertificateClient(vaultUri: new Uri(config.KeyVaultConnectionString), credential: new DefaultAzureCredential());
var certClient = new CertificateClient(vaultUri: new Uri(config.KeyVaultConnectionString), credential: new ManagedIdentityCredential ());
var certificate = await certClient.DownloadCertificateAsync(config.NemsMeshKeyName);
cohortManagerPrivateKey = certificate.Value;

// Get MESH public certificates (CA chain)
var secretClient = new SecretClient(vaultUri: new Uri(config.KeyVaultConnectionString), credential: new DefaultAzureCredential());
var secretClient = new SecretClient(vaultUri: new Uri(config.KeyVaultConnectionString), credential: new ManagedIdentityCredential ());
string base64Cert = (await secretClient.GetSecretAsync(config.NemsMeshCertName)).Value.Value;
meshCerts = CertificateHelper.GetCertificatesFromString(base64Cert);
}
Expand Down
4 changes: 2 additions & 2 deletions application/CohortManager/src/Functions/Shared/Common/Extensions/AzureQueueExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public static IHostBuilder AddServiceBusClient(this IHostBuilder hostBuilder, st
else
{
builder.AddServiceBusClientWithNamespace(serviceBusConnectionString)
.WithCredential(new DefaultAzureCredential());
.WithCredential(new ManagedIdentityCredential ());
}
});
_.AddSingleton<IQueueClient, AzureServiceBusClient>();
Expand Down Expand Up @@ -68,7 +68,7 @@ public static IHostBuilder AddKeyedAzureQueues(this IHostBuilder hostBuilder, bo
else
{
builder.AddServiceBusClientWithNamespace(serviceBusConnectionString)
.WithCredential(new DefaultAzureCredential());
.WithCredential(new ManagedIdentityCredential ());
}
});
_.AddKeyedSingleton<IQueueClient, AzureServiceBusClient>(keyName);
Expand Down
2 changes: 1 addition & 1 deletion application/CohortManager/src/Functions/Shared/Common/Extensions/ConfigurationExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ private static IConfiguration CreateConfiguration(string? keyVaultUrl = null, Li
if(keyVaultUrl != null){
try
{
configBuilder.AddAzureKeyVault(new Uri(keyVaultUrl), new DefaultAzureCredential(), new AzureKeyVaultConfigurationOptions());
configBuilder.AddAzureKeyVault(new Uri(keyVaultUrl), new ManagedIdentityCredential (), new AzureKeyVaultConfigurationOptions());
}
catch (Exception ex)
{
Expand Down
4 changes: 2 additions & 2 deletions application/CohortManager/src/Functions/Shared/Common/Extensions/JwtTokenExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ public static IHostBuilder AddJwtTokenSigning(this IHostBuilder hostBuilder, boo
JwtPrivateKey jwtPrivateKey;
try
{
// Azure
// Azure
hostBuilder.AddConfiguration<JwtTokenServiceConfig>(out JwtTokenServiceConfig config);
if (!string.IsNullOrEmpty(config.KeyVaultConnectionString))
{
var certClient = new CertificateClient(vaultUri: new Uri(config.KeyVaultConnectionString), credential: new DefaultAzureCredential());
var certClient = new CertificateClient(vaultUri: new Uri(config.KeyVaultConnectionString), credential: new ManagedIdentityCredential ());
Response<X509Certificate2> certResponse = certClient.DownloadCertificate(config.KeyNamePrivateKey);

logger.LogInformation("got certificate from key vault");
Expand Down
Loading